Fix uniprot URL link #363
Closed
Fix uniprot URL link #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
query was not downloading any sequences before (for UP000005640). Change "yes" to "true" and it seems to be working for me
|
I Joshua. Thank you for sending this PR. I already have a patch ready to ship now with the fixes. Unfortunately, the changes required more than just changing one parameter format. I won't accept this because the patch is implementing a different approach with a distinct end point. Regardless, I really appreciate you sending this. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
query was not downloading any sequences before (for UP000005640). By changing "yes" to "true" and it seems to be working for me.
Note I am not familiar with the go language however I don't think this should break anything.
Also not sure if the previous statement does not work anymore or if I am just trying to fetch the database on an unlucky day.