Fix broken link and add explanatory variables #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Fabian. This will fix the change with the URL. I'm not sure when that happened. One change I'll do to your code is to remove the checking of the minor version. We add minor fixes with higher frequency than other changes, so we will focus on only alerting people when new features are added. |
|
I think it is nice to get the alert whenever a newer version is available. Even if it is a bug fix release. Take the UniProt API fix - or will that be a major version? Downloads and the installation are fast ;-) |
|
And the check was there before - I only rearranged the code somewhat to add explanatory variables and remove repeated logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.