feat: the credential script should support both username and password (…

…#2875)

pkg/auth/auth.go

@@ -201,7 +201,7 @@ func (c *Credentials) execScript(cmdPath string, kind string, timeout string, e
 		return response, nil
 	}
 
-	// If JSON parsing fails or the data is empty,
+	// If YAML parsing fails or the data is empty,
 	// assume the output is the data (password or certificate) in plain text for backward compatibility.
 	response.Data = strings.TrimSpace(stdout.String())
 	return response, nil

pkg/auth/auth_test.go

@@ -477,7 +477,7 @@ Pollers:
 			pollerName: "test",
 			want: PollerAuth{
 				Username:            "username", // Fallback to the username provided in the poller configuration
-				Password:            "script-password",
+				Password:            "password #\"`!@#$%^&*()-=[]|:'<>/ password",
 				HasCredentialScript: true,
 			},
 			yaml: `
@@ -520,6 +520,24 @@ Pollers:
     addr: a.b.c
     credentials_script:
       path: testdata/get_password_plain
+`,
+		},
+
+		{
+			name:       "credentials_script returns username and password in YAML via Heredoc",
+			pollerName: "test",
+			want: PollerAuth{
+				Username:            "myuser",
+				Password:            "my # password",
+				HasCredentialScript: true,
+			},
+			yaml: `
+Pollers:
+  test:
+    addr: a.b.c
+    username: username
+    credentials_script:
+      path: testdata/get_credentials_yaml_heredoc
 `,
 		},
 	}

pkg/auth/testdata/get_credentials_yaml

@@ -1,4 +1,4 @@
 #!/bin/bash
 # Used by pkg/auth/auth_test.go
-echo "username: script-username"
-echo "password: script-password"
+echo 'username: script-username'
+echo 'password: script-password'

pkg/auth/testdata/get_credentials_yaml_heredoc

@@ -0,0 +1,6 @@
+#!/bin/bash
+# Used by pkg/auth/auth_test.go
+cat << EOF
+username: myuser
+password: "my # password"
+EOF

pkg/auth/testdata/get_credentials_yaml_password

@@ -1,3 +1,6 @@
 #!/bin/bash
 # Used by pkg/auth/auth_test.go
-echo "password: script-password"
+# Single quotes are used to avoid escaping special characters
+# Single quotes can not contain single quotes, so we use '\'' to close
+# the single quote, add a single quote, and then open the single quote again
+echo 'password: "password #\"`!@#$%^&*()-=[]|:'\''<>/ password"'

pkg/auth/testdata/get_password_plain

@@ -1,3 +1,3 @@
 #!/bin/bash
 # Used by pkg/auth/auth_test.go
-echo "plain-text-password"
+echo 'plain-text-password'