Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the credential script should support both username and password #2875

Merged
merged 1 commit into from
May 6, 2024
Merged

feat: the credential script should support both username and password #2875

merged 1 commit into from
May 6, 2024

Conversation

cgrinds
Copy link
Collaborator

@cgrinds cgrinds commented May 3, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label May 3, 2024
@rahulguptajss rahulguptajss merged commit dc9790c into rg2-cd-script May 6, 2024
3 checks passed
@rahulguptajss rahulguptajss deleted the cbg-credentials-script branch May 6, 2024 05:42
rahulguptajss added a commit that referenced this pull request May 6, 2024
@rahulguptajss @cgrinds
feat: credentials script should support both username and password (#…
788f634 
…2870)

* feat: credentials script should support both username and password

* feat: address review comments

* feat: the credential script should support both username and password (#2875)

* feat: address review comments

---------

Co-authored-by: Chris Grindstaff <chris@gstaff.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulguptajss rahulguptajss rahulguptajss approved these changes

@Hardikl Hardikl Awaiting requested review from Hardikl

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrinds @rahulguptajss