Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect external_service_op counters #1879

Closed
mamoep opened this issue Mar 30, 2023 · 4 comments · Fixed by #1941
Closed

Collect external_service_op counters #1879

mamoep opened this issue Mar 30, 2023 · 4 comments · Fixed by #1941
Labels

Comments

@mamoep
Copy link

mamoep commented Mar 30, 2023

Is your feature request related to a problem? Please describe.
I want to see the latency to my LDAP server.

Describe the solution you'd like
Please add collection of external_service_op counters and a corresponding dashboard.

@mamoep mamoep added the feature New feature or request label Mar 30, 2023
@cgrinds
Copy link
Collaborator

cgrinds commented Mar 30, 2023

Thanks @mamoep we'll take a look

@Hardikl
Copy link
Contributor

Hardikl commented Apr 17, 2023

Hi @mamoep

As part of this issue, We would be adding the external_service_op object in ZapiPerf collector and below are the list of counters which are available from this object.

counters:
  - instance_name
  - instance_uuid
  - last_modified_timestamp
  - node_name            
  - num_not_found_responses
  - num_request_failures
  - num_requests_sent
  - num_responses_received
  - num_successful_responses
  - num_timeouts
  - operation
  - process_name
  - request_latency
  - request_latency_hist
  - server_ip_address
  - server_name
  - service_name
  - vserver_name          

What other counters would you like to monitor/collect along with the latency(request_latency) to LDAP server?

@mamoep
Copy link
Author

mamoep commented Apr 17, 2023

These all would be helpful in my opinion.

  • num_not_found_responses
  • num_request_failures
  • num_requests_sent
  • num_responses_received
  • num_successful_responses
  • num_timeouts
  • request_latency_hist

@cgrinds
Copy link
Collaborator

cgrinds commented May 1, 2023

Verified on 3ffa2eb

2023-05-01T08:34:12-04:00 INF collector/collector.go:483 > Collected Poller=sar apiMs=552 calcMs=0 collector=ZapiPerf:ExternalServiceOperation instances=10 metrics=470 parseMs=2 pluginMs=0 skips=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants