feat: collect external_service_op perf object #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hardikl
changed the title
Hardikl
force-pushed
the
external_service_op
branch
2 times, most recently
from
e1fd79e
to
3d1fd72
Compare
|
moving to draft as it is WIP |
|
|
# Conflicts: # integration/test/data/counter_data.go
|
Ready to review |
|
Nice job @Hardikl - since the object collector is disabled by default, this dashboard needs a row/note saying it needs to be enabled similar to Workload dashboards |
cgrinds
reviewed
Apr 24, 2023
|
Couple of issues were identified as many more labels were included and started with plugin go way, then identified which labels would be sufficient for this. Then tried to solve same by moving them to template LabelAgent plugin, but these external service ops are across cluster, so just svm, service_name and operation won't be giving the exact result. That's where I need to put changes in plugin go only with unique key as: Not a clean way of doing this, but this is what I found. |
cgrinds
approved these changes
Apr 27, 2023
rahulguptajss
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.