Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absent metric nic_state used in dashboards #486

Closed
rahulguptajss opened this issue Sep 1, 2021 · 2 comments · Fixed by #487
Closed

Absent metric nic_state used in dashboards #486

rahulguptajss opened this issue Sep 1, 2021 · 2 comments · Fixed by #487
Labels
bug Something isn't working status/done

Comments

@rahulguptajss
Copy link
Contributor

Several dashboards like Network Dashboard, Network Detail dashboard, nvme fc dashboard are using nic_state which is
not a metric exposed by harvest. Due to this, Status field is not available in these dahsboards.
We do have state label in nic_labels and a metric as nic_status.
We should be using value_to_num for mapping status https://github.com/NetApp/harvest/blob/077ffc71c5d30e9f08112402633fe4b79734b629/cmd/poller/plugin/README.md#value_to_num

@rahulguptajss
Copy link
Contributor Author

not in 21.08.0. This needs testing for next release.

@Hardikl Hardikl self-assigned this Oct 28, 2021
@Hardikl
Copy link
Contributor

Hardikl commented Oct 28, 2021

Build used for last release: harvest-21.08.0-6.x86_64.rpm
Build used to test latest: harvest-21.10.2700-nightly.x86_64.rpm

  1. Network dashboard:

previous:
image

now:
image

  1. Network detail:

previous:
image

now:
image

  1. Nvme fc :

previous:
image

now:
image

  1. metrics:

previous:
[root@scspb2506824001 28_10]# curl -s 'http://localhost:12992/metrics' |grep nic_status | wc -l
28
[root@scspb2506824001 28_10]# curl -s 'http://localhost:12992/metrics' |grep nic_new_status | wc -l
0

now:
[root@scspb2506824001 harvest]# curl -s 'http://localhost:12992/metrics' | grep nic_status | wc -l
28
[root@scspb2506824001 harvest]# curl -s 'http://localhost:12992/metrics' | grep nic_new_status | wc -l
28
[root@scspb2506824001 harvest]#

After the upgrade, folder structure looks like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants