Label Creation Issue

[rahulguptajss]

Label path generation logic in harvest is incorrect. Refer method https://github.com/NetApp/harvest/blob/main/cmd/collectors/zapi/collector/parsers.go#L132
It ends up creating below highlighted labels for the template. This needs to be fixed. Only workaround currently is to override label names genration logic using =>

name:                     Spare
query:                    aggr-spare-get-iter
object:                   spare
collect_only_labels:      true
counters:
  aggr-spare-disk-info:
    - ^^disk                       #Generates label path as aggr-disk
    - ^disk-type                 #Generates label path as aggr-disk-type
    - ^is-disk-zeroed		=> is_disk_zeroed            #This gets correctly generated as is_disk_zeroed
    - ^^original-owner   => original_owner                       #This gets correctly generated as original_owner
export_options:
  instance_keys:
    - disk
    - original_owner
  instance_labels:
    - disk_type
    - is_disk_zeroed

[cgrinds]

as discussed on Slack, Rahul mentioned that if you change this it works as expected. Be explicit.

- ^^disk     => disk
- ^disk-type => disk_type