Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added 3 panels supported with relationshipId data link #1642

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Dec 23, 2022

Changes:

  • Added hidden SnapMirrorID var
  • Added 3 panels: Transfer Duration, Lag Time and Transfer Data with SnapMirrorID filter support
  • Added ID column in Last Transfer table with data link - which passes Datacenter, SourceCluster and SnapMirrorID.

SnapMirror Dashboard:
image

When Clicked on ID link:
image

Open issue:
Grafana dynamic link seems to be changed always when we do re-import, so again we need to update the data link of ID column accordingly. Need to check if any feasible solution for this.

@cla-bot cla-bot bot added the cla-signed label Dec 23, 2022
@Hardikl Hardikl linked an issue Dec 23, 2022 that may be closed by this pull request
@Hardikl
Copy link
Contributor Author

Hardikl commented Jan 11, 2023

As we passing the empty ("") uid in all the dashboards, so Grafana would provide unique uid for them at each import/re-import.
Due to this, data link of any panel or dashboard won't be same across import. Hence, we can't support data link.

Changing approach to add Id variable along with the Id column in table and based on that var, newly added 3 panels will be filtered.

image

image

image

@rahulguptajss
Copy link
Contributor

Snapmirror id as filter is not useful as these Ids are not user friendly. It will be better to filter them by destination,source svm like other panels.

@Hardikl
Copy link
Contributor Author

Hardikl commented Jan 18, 2023

Added Source Volume and Destination Volume vars and added description for 4 panels as:
Must select Source Volume/Destination Volume for detail of single relationship

Full dashboard:
image

If select source/destination volume:
image

@Hardikl Hardikl merged commit a6ee961 into main Jan 18, 2023
@Hardikl Hardikl deleted the snapmirror_add_panel branch January 18, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Panels for Snapmirror dashboard
2 participants