fix: handle min-max for network dashboard #1763
Conversation
cmd/tools/grafana/dashboard_test.go
Outdated
| @@ -221,6 +226,18 @@ func doPanel(pathPrefix string, key gjson.Result, value gjson.Result, mt *metric | |||
| } | |||
| } | |||
|
|
|||
| // In case of gradient-gauge and percent(0.0-1.0), we must override min and max value | |||
| for _, properties := range propertiesMap { | |||
| if properties["unit"] == "percentunit" && properties["custom.displayMode"] == "gradient-gauge" { | |||
There was a problem hiding this comment.
Does it only apply to gradient-gauge?
There was a problem hiding this comment.
Checked with other types which displayed value other than text.
Working as expected with:
color-background-solid
color-background
Don't work as expected with:
lcd-gauge
basic
Will add below 2 types in that condition
| @@ -639,6 +639,14 @@ | |||
| } | |||
| ] | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
could you share an example of before and after. A live setup will be helpful to see.
There was a problem hiding this comment.
I have added Network Updated dashboard for testing in 10.195.64.86 machine.
In our clusters, all the values of nic_util_percent are very less.
For testing purpose only, just multiply value by 100 in query #c in both the places.
- Screenshot from old Network dashboard where no min-max set
- Screenshot from updated network dashboard where min-max values are set
There was a problem hiding this comment.
some of the overrides are not found. Could you check and remove stale entries
NVMe/FC portsas this table don't have column #C forused%