Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge compliance and security dashboard + added ARW fields #2207

Merged
merged 10 commits into from
Aug 3, 2023
Merged

feat: merge compliance and security dashboard + added ARW fields #2207

merged 10 commits into from
Aug 3, 2023

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Jul 14, 2023 •
edited
Loading

These Tasks would be covered here:

  • Merge Compliance dashboard to Security dashboard
  • Add Info details in Compliance dashboard regarding this change
  • Add snapshot policy field
  • Add snapshot autodelete field
  • Add SVM configured for ARW
  • Add Volumes monitored by ARW
  • Add Column as Learning mode completed and switch to Active mode
  • Add cluster notification/Auto update REST call
  • Add cluster notification/Auto update ZAPI call
  • UI enhancement

Security dashboard:
image

Compliance dashboard:
image

@cla-bot cla-bot bot added the cla-signed label Jul 14, 2023
@Hardikl Hardikl marked this pull request as draft July 14, 2023 14:29
@Hardikl Hardikl linked an issue Jul 20, 2023 that may be closed by this pull request
Harvest enhancement for Security hardening guide #2187
Closed
@Hardikl Hardikl marked this pull request as ready for review July 24, 2023 12:20
cgrinds
cgrinds reviewed Jul 24, 2023
View reviewed changes
cmd/collectors/rest/plugins/volume/volume.go
instanceKeys := exportOptions.NewChildS("instance_keys", "")
instanceKeys.NewChildS("", "ArwStatus")
my.arw.SetExportOptions(exportOptions)
_, err = my.arw.NewMetricFloat64("status", "status")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid to ignore error here since the matrix was created a few lines above

cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
grafana/dashboards/cmode/compliance.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/security.json Outdated Show resolved Hide resolved
rahulguptajss
rahulguptajss reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@rahulguptajss rahulguptajss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to add panel column descriptions where applicable for this dashboard.

cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cgrinds
cgrinds reviewed Jul 25, 2023
View reviewed changes
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
@Hardikl
Copy link
Contributor Author

Hardikl commented Jul 25, 2023

Good to add panel column descriptions where applicable for this dashboard.

It's about 20 columns now in this panel, trying to accommodate them with less wording. Update it in next commit.

rahulguptajss
rahulguptajss reviewed Jul 31, 2023
View reviewed changes
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/volume/volume.go Outdated Show resolved Hide resolved
@cgrinds cgrinds merged commit 084fb11 into main Aug 3, 2023
9 checks passed
@cgrinds cgrinds deleted the hl_security_guide branch August 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds left review comments

@rahulguptajss rahulguptajss rahulguptajss approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harvest enhancement for Security hardening guide
3 participants
@Hardikl @cgrinds @rahulguptajss