feat: support flexgroup constituents in template #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # conf/rest/9.10.0/volume.yaml # conf/rest/9.9.0/volume.yaml
cgrinds
reviewed
Oct 11, 2023
|
Any impact to published metrics? |
This change would only increase the # records of the existing metrics, doesn't add/change the shape of existing ones. |
rahulguptajss
previously approved these changes
Oct 13, 2023
changed to false for default. |
conf/rest/9.10.0/volume.yaml
Outdated
| @@ -79,7 +79,7 @@ plugins: | |||
| - Volume: | |||
| schedule: | |||
| - data: 15m # should be multiple of poll duration | |||
| include_constituents: true | |||
| include_constituents: false | |||
There was a problem hiding this comment.
needs dashboard text also about the steps needed to enable dashboard
|
How about this description ? |
rahulguptajss
approved these changes
Oct 17, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting one flag
includeConstituentsin all volume templates, which can decide to export flexgroup constituents or not from Harvest poller.Changes:
For Zapi,
Config api gives all the records, flag
includeConstituentswill control constituents records in plugin.For ZapiPerf,
Perf api gives all the records, flag
includeConstituentswill control constituents records in plugin.For RestPerf,
Perf api gives all the records, flag
includeConstituentswill control constituents records in plugin.For Rest,
Public api either gives Flexgroup and Flexvols Or only Flexgroup_constituents but not all.
Used private api gives all the records, Then call public api 2 times for fetching all config details for them. 1 with filter
is_constituent = falseand 2 with filteris_constituent = true. Later, flagincludeConstituentswill control constituents records in plugin.One alternate option would be to duplicate volume template based on
is_constituentfilter, But I would not be inclined towards it as maintenance cost and complexity to User while update/add metrics in both.