Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore performance counters with partial aggregation #2775

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

rahulguptajss
Copy link
Contributor

PR with bool variable in Instance struct

cgrinds
cgrinds previously approved these changes Mar 25, 2024
cmd/collectors/zapiperf/zapiperf.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf_test.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rahulguptajss rahulguptajss merged commit d7ef913 into main Mar 26, 2024
10 checks passed
@rahulguptajss rahulguptajss deleted the rg2-perf-partial-bool branch March 26, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvest should ignore performance counters with partial aggregation
3 participants