Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create resolution metrics for health alerts #2977

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat: Create resolution metrics for health alerts #2977

merged 3 commits into from
Jun 12, 2024

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2024
@rahulguptajss rahulguptajss linked an issue Jun 10, 2024 that may be closed by this pull request
Harvest should create resolution metrics for health alerts #2804
Closed
Hardikl
Hardikl previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated at each poll, so retention/validity of health metrics is only for config data duration time, right ?

Any doc update required for this ?

cmd/collectors/rest/plugins/health/health_test.go Outdated Show resolved Hide resolved
@rahulguptajss
Copy link
Contributor Author

This will be updated at each poll, so retention/validity of health metrics is only for config data duration time, right ?

Any doc update required for this ?

Yes, last collected data will be kept in memory. Not sure about doc, We can discuss.

Hardikl
Hardikl previously approved these changes Jun 11, 2024
View reviewed changes
cgrinds
cgrinds previously approved these changes Jun 11, 2024
View reviewed changes
@rahulguptajss
Merge remote-tracking branch 'origin/main' into rg2-health-resolution
8e770bf 
# Conflicts:
#	grafana/dashboards/cmode/datacenter.json
@rahulguptajss rahulguptajss dismissed stale reviews from cgrinds and Hardikl via 8e770bf June 12, 2024 05:46
@cgrinds cgrinds merged commit 0cdb0c7 into main Jun 12, 2024
6 checks passed
@cgrinds cgrinds deleted the rg2-health-resolution branch June 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harvest should create resolution metrics for health alerts
3 participants
@rahulguptajss @cgrinds @Hardikl