-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please support XFS for iSCSI docker volumes #73
Labels
Comments
Tracked internally as [US2518] |
@ragesaq and I tried to change the util.FormatVolume filesystem parameter to "xfs" instead of "ext4", but the containers could not be created after the change (see bottom log) diff --git a/storage_drivers/ontap_san.go b/storage_drivers/ontap_san.go
index b107975..6c18569 100644
--- a/storage_drivers/ontap_san.go
+++ b/storage_drivers/ontap_san.go
@@ -397,7 +397,7 @@ func (d *OntapSANStorageDriver) Attach(name, mountpoint string, opts map[string]
// put a filesystem on it if there isn't one already there
if e.Filesystem == "" {
// format it
- err := utils.FormatVolume(deviceToUse, "ext4") // TODO externalize fsType
+ err := utils.FormatVolume(deviceToUse, "xfs") // TODO externalize fsType
if err != nil {
return fmt.Errorf("Problem formatting lun: %v device: %v error: %v", name, deviceToUse, err) Errors such as these are produced after the above change -
Any assistance is welcomed! Thanks |
j-griffith
added a commit
to j-griffith/netappdvp
that referenced
this issue
Sep 6, 2017
This change simply adds the ability to specify a file system type to use during volume creation. The available options are xfs, ext3 and ext4 (default). This change will allow the user to specify fstype as an option on create for example: `docker volume create -d solidifre -o fstype=xfs my-xfs-volume` If no fstype option is specified or an invalid choice is specified then the default ext4 fs will be used. Partially addresses Github Issue: NetApp#73 (SF support only) Partially addresses internal tracking issue: US2518 (SF support only)
j-griffith
added a commit
to j-griffith/netappdvp
that referenced
this issue
Sep 6, 2017
This change simply adds the ability to specify a file system type to use during volume creation. The available options are xfs, ext3 and ext4 (default). This change will allow the user to specify fstype as an option on create for example: `docker volume create -d solidifre -o fstype=xfs my-xfs-volume` If no fstype option is specified or an invalid choice is specified then the default ext4 fs will be used. Partially addresses Github Issue: NetApp#73 (SF support only) Partially addresses internal tracking issue: US2518 (SF support only)
netapp-ci
pushed a commit
that referenced
this issue
Sep 14, 2017
This change simply adds the ability to specify a file system type to use during volume creation. The available options are xfs, ext3 and ext4 (default). This change will allow the user to specify fileSystemType as an option on create for example: `docker volume create -d netapp -o fileSystemType=xfs my-xfs-volume` If no fstype option is specified or an invalid choice is specified then the default ext4 fs will be used. Partially addresses Github Issue: #73 (SF support only) Partially addresses internal tracking issue: US2518 (SF support only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see in the code some of the groundwork to support XFS for the filesystem backing the iscsi docker volumes. This would be a nice addition as XFS allows for growing, which would also be a nice feature to add to the netappdvp plugin.
Sometimes you just want to grow a volume without wiping out what is already there.
The text was updated successfully, but these errors were encountered: