Fix up name prefix messiness #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the things added to the ndvp driver in it's initial release was a name-prefix default that would prepend all resource names with a default of `netappdvp-`. We would perform all look ups using the volume name and this prefix. Due to some incompatabilities between products and the use of `-` vs `_`, we modified the SolidFire driver to use attributes as the mapping method instead of the volume-name and juggling the prefix. This broke access to legacy installs that upgraded, becuase they wouldn't have the attribute and thus never find the volumes. The name prefixes are actually just troublesome, between upgrade issues like the one described, and errors in deployments (other ndvp nodes not matching their configs) it's just better to not use prefixes. This change does away with prefixes for the SolidFire driver by checking at the main ndvp interface and NOT munging the name. We then leave it up to the driver to do any name munging if neeeded. To address the issue of legacy volumes after an upgrade, I implemented a wrapper method to getVolumes that will use the old method of looking by name with prefix if the search by attributes fails.
One of the things added to the ndvp driver in it's initial release was a name-prefix default that would prepend all resource names with a default of `netappdvp-`. We would perform all look ups using the volume name and this prefix. Due to some incompatabilities between products and the use of `-` vs `_`, we modified the SolidFire driver to use attributes as the mapping method instead of the volume-name and juggling the prefix. This broke access to legacy installs that upgraded, becuase they wouldn't have the attribute and thus never find the volumes. The name prefixes are actually just troublesome, between upgrade issues like the one described, and errors in deployments (other ndvp nodes not matching their configs) it's just better to not use prefixes. This change does away with prefixes for the SolidFire driver by checking at the main ndvp interface and NOT munging the name. We then leave it up to the driver to do any name munging if neeeded. To address the issue of legacy volumes after an upgrade, I implemented a wrapper method to getVolumes that will use the old method of looking by name with prefix if the search by attributes fails.
…nto fix_name_prefixes
…nto fix_name_prefixes
…appdvp into fix_name_prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things added to the ndvp driver in it's initial release was a
name-prefix default that would prepend all resource names with a default
of
netappdvp-. We would perform all look ups using the volume name andthis prefix.
Due to some incompatabilities between products and the use of
-vs_,we modified the SolidFire driver to use attributes as the mapping method
instead of the volume-name and juggling the prefix. This broke access to
legacy installs that upgraded, becuase they wouldn't have the attribute
and thus never find the volumes.
The name prefixes are actually just troublesome, between upgrade issues like
the one described, and errors in deployments (other ndvp nodes not matching
their configs) it's just better to not use prefixes.
This change does away with prefixes for the SolidFire driver by checking at the
main ndvp interface and NOT munging the name. We then leave it up to the
driver to do any name munging if neeeded.
To address the issue of legacy volumes after an upgrade, I implemented a
wrapper method to getVolumes that will use the old method of looking by name
with prefix if the search by attributes fails.