Add GCP validation for project and shared_vpc_project_number #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three commits.
Fix typo (montly -> monthly) in variable name. Cosmetic
Add validation for "project" and "shared_vpc_project_number" attributes
On GCP, users often confuse project_ID (mostly used within GCP) and project_number (which the CVS API uses). This led to multiple annoyances when users specified the alpha-numerical project_ID , instead of the numerical project_number. When doing so, the error message is less than helpful:
This commit adds a validation to "project" and "shared_vpc_project_number" to be numeric. Since project_id needs to start with a lowercase letter, this will prevent users from specifying a project_id and will return an helpful error message. The commit misses tests to test the validation. Manual tests did work.
Additionally, my editor (VSCode) enforces some formatting rules automatically. Some lines got cleaned up.