-
Notifications
You must be signed in to change notification settings - Fork 462
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Something from <Someone>'s list: some messages have hardcoded references to "helmet" which sound strange when the character is wearing a hat or cap. helm_simple_name() is comparable to the existing cloak_simple_name(). It returns "helm" or "hat" depending upon whether the helmet provides the same protection that yields the assorted repetitions of "fortunately, you are wearing a hard helmet". This choice ends up categorizing elven leather helm as a hat (which I think is ok given that its undiscovered description is "leather hat"), contrary to <Someone>'s suggestion that the distinction be made based on whether the helmet was made of cloth. I started on this a year and a half ago but didn't commit it. Unfortunately I don't remember why and haven't done any significant additional work now--just recovered from some intervening bit rot and confirmed that the patch as is seems to be working ok (in the trunk; the branch side has not been tested). I suspect that I meant to look for additional helmet messages which could benefit from conditional headgear description. (Those "hard helmet" ones don't need it, although they should perhaps be moved into a common routine instead of being replicated.)
- Loading branch information
nethack.rankin
committed
Nov 13, 2004
1 parent
88dad93
commit 7672a2c
Showing
10 changed files
with
67 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters