Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Deprecating dialogs from the Office API library #360

Closed
jozefizso opened this issue Sep 4, 2022 · 1 comment · Fixed by #361
Closed

⚠️ Deprecating dialogs from the Office API library #360

jozefizso opened this issue Sep 4, 2022 · 1 comment · Fixed by #361
Assignees
Milestone

Comments

@jozefizso
Copy link
Member

The OfficeApi library has several Win Forms dialogs defined. These dialogs are causing build issues when transitioning to .NET 6 and the dotnet build system. We will remove them from the 1.9 release and these dialogs will be available from a new package which will isolate the Win Forms code.

List of dialogs:

  • AboutDialog
  • DiagnosticsDialog
  • ErrorDialog
  • PropertyGridDialog
  • RichTextDialog
  • ToolsDialog

Issue Details

When building the project with dotnet build instead of msbuild the embeded images in the resource files will cause this error:

C:\Program Files\dotnet\sdk\6.0.400\Microsoft.Common.CurrentVersion.targets(3262,5):
error MSB3823: Non-string resources require the property GenerateResourceUsePreserializedResources to be set to true. [OfficeApi.csproj]
error MSB3822: Non-string resources require the System.Resources.Extensions assembly at runtime, but it was not found in this project's references. [OfficeApi.csproj]
@jozefizso jozefizso added this to the 1.9.0 milestone Sep 4, 2022
@jozefizso jozefizso self-assigned this Sep 4, 2022
@jozefizso
Copy link
Member Author

jozefizso commented Sep 4, 2022

Breaking changes

  • Method DialogUtils.TryGetApplicationVisible() moved to CommonUtils.TryGetApplicationVisible()
  • Removed OutlookDialogUtils class. The OutlookDialogUtils.HostVisible property is available in the ApplicationUtils class as ApplicationUtils.Visible property.

jozefizso added a commit that referenced this issue Sep 4, 2022
Deprecating dialogs from the Office API library #360
@jozefizso jozefizso changed the title Deprecating dialogs from the Office API library ⚠️ Deprecating dialogs from the Office API library Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant