Avoid repeating field definitions #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support::Sublist already defines the replace_all field.
In adding the start of search_only_fields, a couple standard fields were mistakenly re-defined as search_only_fields, which ended up excluding them when pushing data to NetSuite, under the guise they were search-only. Now it's impossible to define the same field twice. As a result, had to fix a number of occurrences of fields repeated between `fields` and another definition (ie `record_refs`, `read_only_fields`, `field`). The only notable fix is on `Invoice`, where `bill_address` and `ship_address` were previously defined as `fields`, then got repeated as `search_only_fields`. In old APIs (<= 2014.1), these seemed to actually be fields, however in newer APIs (>= 2014.2), they no longer are. I'm erring on the side of newer APIs here, removing them as `fields` and leaving them as `search_only_fields`. Fixed NetSweet#486
|
@cgunther great change, thanks! Re: invoice change, this shouldn't cause any breaking changes for users unless they are on a 2014 API version. I think biasing towards the most recent API version makes sense. Would be good to note this in the changelog though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adding the start of search_only_fields, a couple standard fields were mistakenly re-defined as search_only_fields, which ended up excluding. them when pushing data to NetSuite, under the guise they were search-only.
Now it's impossible to define the same field twice.
As a result, had to fix a number of occurrences of fields repeated between
fieldsand another definition (ierecord_refs,read_only_fields,field).The only notable fix is on
Invoice, wherebill_addressandship_addresswere previously defined asfields, then got repeated assearch_only_fields. In old APIs (<= 2014.1), these seemed to actually be fields, however in newer APIs (>= 2014.2), they no longer are. I'm erring on the side of newer APIs here, removing them asfieldsand leaving them assearch_only_fields.Fixed #486