Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont crash if suitetalk returns empty <platformCore:searchRowList/> #574

Merged
merged 2 commits into from Mar 26, 2023

Conversation

ericcj
Copy link
Contributor

@ericcj ericcj commented Mar 16, 2023

The client should just yield the blank page returned instead of crashing, but to ever receive this seems like a bug in suitetalk since we're using results_in_batches but on the final page sometimes a successful result is returned with no rows, probably because the underlying data no longer matches the search since our pagination takes an hour or so and we're running it across day boundaries, but you'd think search_id would represent an isolated view of the data we're paginating. we haven't captured the log to see if total_records changes, but obviously total_pages doesn't since it successfully accepts page_index but just doesn't return any rows.

@iloveitaly
Copy link
Member

@ericcj can you include a test for this with a XML fixture? Thanks for the contribution!

@ericcj
Copy link
Contributor Author

ericcj commented Mar 22, 2023

@iloveitaly done

@iloveitaly
Copy link
Member

Awesome, thank you!

@iloveitaly iloveitaly merged commit a220f69 into NetSweet:master Mar 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants