Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

Future of Coordinate class #55

Closed
FObermaier opened this issue Sep 27, 2018 · 1 comment
Closed

Future of Coordinate class #55

FObermaier opened this issue Sep 27, 2018 · 1 comment
Assignees
@FObermaier
Labels
breaking change Doing this would break either source or binary compatibility with existing versions.
Milestone
v2.0

Comments

@FObermaier
Copy link
Member

The former Coordinate class has been disected into four hierarchical classes:

  • CoordinateXY
    • CoordinateXYM
    • CoordinateXYZ
      • CoordinateXYZM

Where applicable, the defined interfaces have been refactored to use CoordinateXY as coordinate class.
Coordinate class has received some conversion operators (implicit vice versa to CoordinateXY and explicit to CoordinateXYZ)

We have two choices:

  • Mark Coordinate obsolete and let it stay around with CoordinateXY et. al. (👍 )
    • Might help transforming dependant projects
    • to be continued
  • Remove Coordinate, strip "XY" off of CoordinateXY et. at. (👎 )
    • Cleaner, less changes in NTS
    • to be continued
@FObermaier FObermaier added this to the v2.0 milestone Sep 27, 2018
@FObermaier FObermaier added the breaking change Doing this would break either source or binary compatibility with existing versions. label Sep 27, 2018
@DGuidi
Copy link
Contributor

DGuidi commented Sep 27, 2018

my two cents:
CoordinateXY => Coordinate
CoordinateXYM => CoordinateM
CoordinateXYZ => CoordinateZ
CoordinateXYZM => CoordinateZM

@FObermaier FObermaier self-assigned this Oct 2, 2018
@FObermaier FObermaier mentioned this issue Nov 22, 2018
Merged
FObermaier added a commit that referenced this issue Feb 14, 2019
@FObermaier
Strip XY from all Coordinate classes
aa35722 
* CoordinateXY -> Coordinate
* CoordinateXYZ -> CoordinateZ
* CoordinateXYM -> CoordinateM
* CoordinateXYZM -> CoordinateZM

Fixes #55
@FObermaier FObermaier mentioned this issue Feb 14, 2019
Merged
FObermaier added a commit that referenced this issue Feb 15, 2019
@FObermaier
Replace Coordinate class with 2D version (#55) (#60)
cc9cc16 
* Delete obsolete Coordinate class
* Strip XY from all Coordinate classes
  * CoordinateXY -> Coordinate
  * CoordinateXYZ -> CoordinateZ
  * CoordinateXYM -> CoordinateM
  * CoordinateXYZM -> CoordinateZM

Fixes #55
@airbreather airbreather mentioned this issue Feb 27, 2019
Closed
31 tasks
@dependabot-preview dependabot-preview bot mentioned this issue Aug 27, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@FObermaier FObermaier

Labels
breaking change Doing this would break either source or binary compatibility with existing versions.
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@DGuidi @FObermaier