Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests from NetTopologySuite.IO.ShapeFile repository #5

Conversation

KubaSzostak
Copy link
Member

No description provided.

@KubaSzostak KubaSzostak changed the title Add Issue123Test Add tests from NetTopologySuite.IO.ShapeFile repository Jul 16, 2022
@KubaSzostak
Copy link
Member Author

Tests which are no longer relevant (for example test of decommissioned GDBReader) are marked with following comment:

// TODO: Remove no longer relevant test

@KubaSzostak
Copy link
Member Author

Questions related to Issue27Fixture.cs:

  1. Is IShapefileFeature + ShapefileFeature required? Currently they are not implemented.
  2. Currently ShapefileReader implements IEnumerable<Feature>. Should it be changed into IEnumerable<IFeature>? Or maybe IEnumerable<IShapefileFeature>?

@KubaSzostak KubaSzostak merged commit 1319476 into NetTopologySuite:test/nts.io.shapefile Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants