Don't seteuid() if process is already running as that uid.

Netatalk · Oct 15, 2023 · 1e49e50 · 1e49e50
1 parent d575ac2
commit 1e49e50
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/etc/afpd/afp_asp.c b/etc/afpd/afp_asp.c
@@ -52,8 +52,11 @@ static void afp_asp_close(AFPObj *obj)
 {
     ASP asp = obj->handle;
 
-    if (seteuid( obj->uid ) < 0) {
-        LOG(log_error, logtype_afpd, "can't seteuid back %s", strerror(errno));
+    if ( obj->uid != geteuid() ) {
+        if (seteuid(obj->uid) < 0) {
+            LOG(log_error, logtype_afpd,
+			"afp_asp_close: can't seteuid back to %i from %i (%s)",
+			obj->uid, geteuid(), strerror(errno));
         exit(EXITERR_SYS);
     }
     close_all_vol();