Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Remove dangerous afprun module from codebase #531

Merged
merged 4 commits into from Oct 16, 2023
Merged

[2.3] Remove dangerous afprun module from codebase #531

merged 4 commits into from Oct 16, 2023

Conversation

dgsga
Copy link
Contributor

@dgsga dgsga commented Oct 15, 2023

No description provided.

@dgsga dgsga requested a review from rdmark October 15, 2023 13:06
@dgsga dgsga self-assigned this Oct 15, 2023
@rdmark
Copy link
Member

rdmark commented Oct 15, 2023

@dgsga Thanks for taking a stab at this! Did you look at the commit from my fork? I think there's an opportunity to remove even more code... rdmark@02823a8

Please also remove the man page documentation for all four options as part of this changeset!

@rdmark rdmark changed the title Remove dangerous afprun module from codebase [2.3] Remove dangerous afprun module from codebase Oct 16, 2023
@rdmark rdmark changed the base branch from branch-netatalk-2-2 to branch-netatalk-2-3 October 16, 2023 09:38
@dgsga dgsga force-pushed the 526-2.2-remove-afprun-functionality branch 3 times, most recently from 62b62f8 to 4128c64 Compare October 16, 2023 19:10
@dgsga
Copy link
Contributor Author

dgsga commented Oct 16, 2023

@dgsga Thanks for taking a stab at this! Did you look at the commit from my fork? I think there's an opportunity to remove even more code... rdmark@02823a8

Please also remove the man page documentation for all four options as part of this changeset!

Done.

@dgsga dgsga force-pushed the 526-2.2-remove-afprun-functionality branch from 4128c64 to 4b69664 Compare October 16, 2023 19:17
@dgsga dgsga force-pushed the 526-2.2-remove-afprun-functionality branch from 1fb2113 to 507efea Compare October 16, 2023 19:20
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark
Copy link
Member

rdmark commented Oct 16, 2023

Looks good! I pushed one small commit to remove a now-unused function parameter. (Thank you Sonar!)

@rdmark rdmark merged commit 345db82 into branch-netatalk-2-3 Oct 16, 2023
5 checks passed
@rdmark rdmark deleted the 526-2.2-remove-afprun-functionality branch October 16, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmark rdmark rdmark approved these changes

Assignees

@dgsga dgsga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgsga @rdmark