Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Remove dangerous afprun module from codebase #531

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[2.3] Remove dangerous afprun module from codebase #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e808e6c
Remove dangerous afprun module from codebase
dgsga Oct 14, 2023
e25ef56
Port other relevant code removal from 2.x repo
dgsga Oct 16, 2023
507efea
AppleVolumes.default.5.xml: remove all pre- and post- exec: commands
dgsga Oct 16, 2023
64ea106
Remove the unused parameter "user".
rdmark Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 1 addition & 58 deletions doc/manual/man/man5/AppleVolumes.default.5.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,16 +365,6 @@
</listitem>
</varlistentry>

<varlistentry>
<term>preexec_close</term>

<listitem>
<para>A non-zero return code from preexec closes the volume
immediately, preventing clients to mount/see the volume
in question.</para>
</listitem>
</varlistentry>

<varlistentry>
<term>ro</term>

Expand All @@ -386,16 +376,6 @@
</listitem>
</varlistentry>

<varlistentry>
<term>root_preexec_close</term>

<listitem>
<para>A non-zero return code from root_preexec closes the
volume immediately, preventing clients to mount/see the volume
in question.</para>
</listitem>
</varlistentry>

<varlistentry>
<term>upriv</term>

Expand Down Expand Up @@ -466,42 +446,6 @@
</listitem>
</varlistentry>

<varlistentry>
<term>preexec:<replaceable>[command]</replaceable></term>

<listitem>
<para>command to be run when the volume is mounted, ignored for user
defined volumes</para>
</listitem>
</varlistentry>

<varlistentry>
<term>postexec:<replaceable>[command]</replaceable></term>

<listitem>
<para>command to be run when the volume is closed, ignored for user
defined volumes</para>
</listitem>
</varlistentry>

<varlistentry>
<term>root_preexec:<replaceable>[command]</replaceable></term>

<listitem>
<para>command to be run as root when the volume is mounted, ignored
for user defined volumes</para>
</listitem>
</varlistentry>

<varlistentry>
<term>root_postexec:<replaceable>[command]</replaceable></term>

<listitem>
<para>command to be run as root when the volume is closed, ignored
for user defined volumes</para>
</listitem>
</varlistentry>

<varlistentry>
<term>rolist:[<option>users/groups</option>]</term>

Expand Down Expand Up @@ -1000,8 +944,7 @@

<listitem>
<para>Don't stat volume path when enumerating volumes list,
useful for automounting or volumes created by a preexec
script.</para>
useful for automounting.</para>
</listitem>
</varlistentry>

Expand Down
2 changes: 1 addition & 1 deletion etc/afpd/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ hash
test_parse_mtab
.deps
.libs
afpd-afp_asp.o afpd-afp_config.o afpd-afp_dsi.o afpd-afp_options.o afpd-afprun.o afpd-afp_util.o afpd-afs.o afpd-appl.o afpd-auth.o afpd-catsearch.o afpd-desktop.o afpd-directory.o afpd-enumerate.o afpd-extattrs.o afpd-filedir.o afpd-file.o afpd-fork.o afpd-gettok.o afpd-hash.o afpd-main.o afpd-mangle.o afpd-messages.o afpd-nfsquota.o afpd-ofork.o afpd-quota.o afpd-status.o afpd-switch.o afpd-uam.o afpd-uid.o afpd-unix.o afpd-volume.o hash-hash.o
afpd-afp_asp.o afpd-afp_config.o afpd-afp_dsi.o afpd-afp_options.o afpd-afp_util.o afpd-afs.o afpd-appl.o afpd-auth.o afpd-catsearch.o afpd-desktop.o afpd-directory.o afpd-enumerate.o afpd-extattrs.o afpd-filedir.o afpd-file.o afpd-fork.o afpd-gettok.o afpd-hash.o afpd-main.o afpd-mangle.o afpd-messages.o afpd-nfsquota.o afpd-ofork.o afpd-quota.o afpd-status.o afpd-switch.o afpd-uam.o afpd-uid.o afpd-unix.o afpd-volume.o hash-hash.o
1 change: 0 additions & 1 deletion etc/afpd/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ afpd_SOURCES = \
afp_options.c \
afp_util.c \
afp_zeroconf.c \
afprun.c \
afs.c \
appl.c \
auth.c \
Expand Down
271 changes: 0 additions & 271 deletions etc/afpd/afprun.c
View file
Open in desktop

This file was deleted.