Validate size of ace_count in FPSetACL request #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
rdmark-issue-364
branch
from
d0b5741
to
facf7a2
Compare
|
Keeping this as Draft until it can be properly tested |
|
Did a smoketest on Ubuntu 22.04.3 -- the ext4 file system has ACLs enabled. The afp_setacl function is called in the Beyond that, more ACL scenarios should probably be tested, but I have no use cases/experiences with ACLs myself. Ideas welcome! |
dgsga
approved these changes
Oct 21, 2023
Signed-off-by: Robert Morris Reviewed-by: Daniel Markstedt <daniel@mindani.net>
rdmark
force-pushed
the
rdmark-issue-364
branch
from
facf7a2
to
8fe7acb
Compare
|
Backported to 2.x #551 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding a potential buffer overrun if the value is too large
Credits: Robert Morris