Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Validate size of ace_count in FPSetACL request #551

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[2.3] Validate size of ace_count in FPSetACL request #551

merged 1 commit into from
Oct 23, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Oct 21, 2023 •
edited
Loading

Avoid potential crash in FPSetACL, #364

@rdmark
Validate size of ace_count in FPSetACL request, GitHub #364
159ac2e 
Signed-off-by: Robert Morris
Reviewed-by: Daniel Markstedt <daniel@mindani.net>
@rdmark rdmark changed the title Validate size of ace_count in FPSetACL request, GitHub #364 [2.3] Validate size of ace_count in FPSetACL request Oct 21, 2023
@rdmark rdmark mentioned this pull request Oct 21, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark
Copy link
Member Author

rdmark commented Oct 23, 2023 •
edited
Loading

FWIW I tried to run a negative test case to see if the check caught a mismatched buffer size. However on Ubuntu I couldn't see evidence that the setacl function is ever called. I referenced this article to check that Linux ACLs were activated on the file system, and then used setfacl to set and revoke ACLs on dirs that were shared by afpd.

https://help.ubuntu.com/community/FilePermissionsACLs

Before release some additional cross platform testing of ACL functionality should be carried out. (I never use it personally)

@rdmark rdmark merged commit 9b34cd2 into branch-netatalk-2-3 Oct 23, 2023
5 checks passed
@rdmark rdmark deleted the rdmark-issue-364-2 branch October 23, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rdmark