Compile spotlight.h only when Spotlight is enabled #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2023
rdmark
force-pushed
the
rdmark-issue-577
branch
from
0d39c33
to
703ff0e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@dgsga Sure, we can use your fix. In fact, why don't we do both? My approach is consistent with f.e. ldapconfig.h and the There may be a good reason not to, but I thought it was worth a conversation. :) |
ghost
approved these changes
Dec 10, 2023
ghost
merged commit
|
@rdmark, I have merged your PR and only the macOS workflow fix component of mine as this seems the best of both worlds. |
ghost
pushed a commit
that referenced
this pull request
May 19, 2024
* Compile spotlight.h only when Spotlight is enabled, #577 * Remove orphaned USE_BUILTIN_TALLOC conditionals
ghost
pushed a commit
that referenced
this pull request
May 19, 2024
* Compile spotlight.h only when Spotlight is enabled, #577 * Remove orphaned USE_BUILTIN_TALLOC conditionals
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dalloc.h header depends on talloc so it shouldn't be imported without the Spotlight toolchain.
Also, the symbols in spotlight.h aren't needed without Spotlight to let's ifdef them away (unless there's a more graceful way to do this?)