Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Rename launchd plist to io.netatalk* and sort file names #765

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Mar 29, 2024

No description provided.

@rdmark
Copy link
Member Author

rdmark commented Mar 29, 2024

This is an experiment for now so keeping as Draft.

@rdmark rdmark changed the title Rename launchd plist to io.netatalk* and sort file names [2.3] Rename launchd plist to io.netatalk* and sort file names Mar 29, 2024
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dgsga
Copy link
Contributor

dgsga commented Mar 29, 2024

It should work fine. I would also rename com.netatalk.daemon.plist.tmpl to io.netatalk.daemon.plist.tmpl and update the relevant makefiles too for the sake of consistency

@rdmark rdmark marked this pull request as ready for review March 29, 2024 23:41
@rdmark
Copy link
Member Author

rdmark commented Mar 30, 2024

@dgsga Haven't I made those changes already in this PR though?

@dgsga
Copy link
Contributor

dgsga commented Mar 30, 2024

@dgsga Haven't I made those changes already in this PR though?

Yes you have!! My apologies for focussing on the lines removed rather than lines added.

@rdmark rdmark merged commit 99732b0 into branch-netatalk-2-3 Mar 30, 2024
8 checks passed
@rdmark rdmark deleted the rdmark-plist-netatalk-io branch March 30, 2024 22:11
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 12, 2024
From upstream's changelog:

New Features

A Dockerfile and container entry script have been added which allows
you to run Netatalk 2 containerized. AppleTalk networking is supported
if the host OS has an AppleTalk network stack. Either build a Docker
image yourself from the code, or pull a pre-built image from Docker Hub.

A macOS style launchd configuration file and netatalkd helper script
has been added. Build it by configuring the build system with the
--enable-macos parameter. Using these allows you to bypass recent
limitations in macOS Sonoma that prevents forking daemons to run.

Netatalk�-F¢s pap is now able to print to an ImageWriter II or LQ�-A
connected to the LocalTalk network, with papstatus providing more
status information for this line of Apple printers.

What's Changed

    [2.3] Create Dockerfile and entry point by @rdmark in
    Netatalk/netatalk#704
    [2.3] Remove binary logo images from revision control by @rdmark
    in Netatalk/netatalk#717
    [2.3] Docker: Unprivileged build; expose ports and volume by
    @rdmark in Netatalk/netatalk#714
    [2.3] Docker: Check for mandatory env variables; more
    configurability by @rdmark in
    Netatalk/netatalk#721
    [2.3] atalkd: Bail out when attempting to -seed a single interface
    by @rdmark in Netatalk/netatalk#720
    [2.3] pap,papstatus: changes to allow Imagewriters to print, and
    nicer status messages by @nutzman in
    Netatalk/netatalk#722
    [2.3] docs: Correct descriptions for afpd -D and -T options by
    @rdmark in Netatalk/netatalk#727
    [2.3] Clean up residual CVS commit headers by @rdmark in
    Netatalk/netatalk#734
    [2.3] docs: Improve man page summaries by @rdmark in
    Netatalk/netatalk#733
    [2.3] docs: Print netatalk version as subtitle, and header on each
    html page by @rdmark in
    Netatalk/netatalk#741
    [2.3] docs: manual XML source improvements, backported from main
    by @rdmark in Netatalk/netatalk#753
    [2.3] Create init scripts for macOS by @rdmark in
    Netatalk/netatalk#757
    [2.3] Detect system docbook stylesheets at configure time by
    @rdmark in Netatalk/netatalk#763
    [2.3] docker: Check for atalkd interface before starting atalkd
    daemons by @rdmark in
    Netatalk/netatalk#769
    [2.3] Rename launchd plist to io.netatalk* and sort file names by
    @rdmark in Netatalk/netatalk#765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants