-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3] Create Dockerfile and entry point #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the two security hotspots reported by Sonar are unavoidable by present constraints. All operations require root access, while we need all files in the tarball/git repo to perform a build... |
pulling back to draft... there's a bug when connecting via Avahi Zeroconf |
bug fixed |
ghost
approved these changes
Feb 7, 2024
rdmark
force-pushed
the
rdmark-docker-v2
branch
from
February 9, 2024 06:37
28cc69d
to
4057b79
Compare
- Requires host networking and NET_ADMIN capabilities. - For Zeroconf, relies on the host running DBUS. - Modified from the original by Eric Harmon, used with permission.
rdmark
force-pushed
the
rdmark-docker-v2
branch
from
February 9, 2024 06:39
4057b79
to
733411a
Compare
Quality Gate failedFailed conditions |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 12, 2024
From upstream's changelog: New Features A Dockerfile and container entry script have been added which allows you to run Netatalk 2 containerized. AppleTalk networking is supported if the host OS has an AppleTalk network stack. Either build a Docker image yourself from the code, or pull a pre-built image from Docker Hub. A macOS style launchd configuration file and netatalkd helper script has been added. Build it by configuring the build system with the --enable-macos parameter. Using these allows you to bypass recent limitations in macOS Sonoma that prevents forking daemons to run. Netatalk�-F¢s pap is now able to print to an ImageWriter II or LQ�-A connected to the LocalTalk network, with papstatus providing more status information for this line of Apple printers. What's Changed [2.3] Create Dockerfile and entry point by @rdmark in Netatalk/netatalk#704 [2.3] Remove binary logo images from revision control by @rdmark in Netatalk/netatalk#717 [2.3] Docker: Unprivileged build; expose ports and volume by @rdmark in Netatalk/netatalk#714 [2.3] Docker: Check for mandatory env variables; more configurability by @rdmark in Netatalk/netatalk#721 [2.3] atalkd: Bail out when attempting to -seed a single interface by @rdmark in Netatalk/netatalk#720 [2.3] pap,papstatus: changes to allow Imagewriters to print, and nicer status messages by @nutzman in Netatalk/netatalk#722 [2.3] docs: Correct descriptions for afpd -D and -T options by @rdmark in Netatalk/netatalk#727 [2.3] Clean up residual CVS commit headers by @rdmark in Netatalk/netatalk#734 [2.3] docs: Improve man page summaries by @rdmark in Netatalk/netatalk#733 [2.3] docs: Print netatalk version as subtitle, and header on each html page by @rdmark in Netatalk/netatalk#741 [2.3] docs: manual XML source improvements, backported from main by @rdmark in Netatalk/netatalk#753 [2.3] Create init scripts for macOS by @rdmark in Netatalk/netatalk#757 [2.3] Detect system docbook stylesheets at configure time by @rdmark in Netatalk/netatalk#763 [2.3] docker: Check for atalkd interface before starting atalkd daemons by @rdmark in Netatalk/netatalk#769 [2.3] Rename launchd plist to io.netatalk* and sort file names by @rdmark in Netatalk/netatalk#765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile and entry point script for running an AFP server + AppleTalk services.
Based on the original POC by eharmon