Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Critical - Tabbed carousel multiple instances get combined #109

Closed
cogniSyb opened this issue Oct 9, 2023 · 1 comment
Closed

Bug - Critical - Tabbed carousel multiple instances get combined #109

cogniSyb opened this issue Oct 9, 2023 · 1 comment
Assignees
@Andrei-Boiangiu
Labels
Bugfix Something isn't working Spillover
Milestone
MT PDP

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Oct 9, 2023 •
edited by Lakshmishri
Loading

When trying to add two tabbed carousels below each other, they get combined into one, and content breaks. See https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/pdp

Result:
Frame 2609240

Expected outcome:
Frame 2609241
@cogniSyb cogniSyb added the Bugfix Something isn't working label Oct 9, 2023
@DanielaPedrochevd DanielaPedrochevd added this to the MT PDP milestone Oct 31, 2023
@Lakshmishri Lakshmishri assigned Lakshmishri and unassigned cogniSyb Nov 10, 2023
@Lakshmishri Lakshmishri mentioned this issue Nov 10, 2023
Merged
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as fixed
as tested on https://109-tabbed-carousel-instances--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/lakshmi/v2/tabbed-carousel

cogniSyb pushed a commit that referenced this issue Nov 15, 2023
@Lakshmishri
Tabbed carousel multiple instances get combined #109 (#167)
ac79c85 
* refactor tabbed carousel
@cogniSyb cogniSyb mentioned this issue Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrei-Boiangiu Andrei-Boiangiu

Labels
Bugfix Something isn't working Spillover
Projects
None yet
Milestone
MT PDP
Development

No branches or pull requests
4 participants
@Lakshmishri @Andrei-Boiangiu @cogniSyb @DanielaPedrochevd