Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbed carousel multiple instances get combined #109 #167

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Tabbed carousel multiple instances get combined #109 #167

merged 4 commits into from
Nov 15, 2023

Conversation

Lakshmishri
Copy link
Collaborator

@Lakshmishri Lakshmishri commented Nov 10, 2023 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 10, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@Lakshmishri Lakshmishri changed the title refactor tabbed carousel Refactor Tabbed carousel Nov 10, 2023
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 10, 2023

Page Scores Audits Google
/drafts/lakshmi/v2/tabbed-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TomaszDziezykNetcentric
Copy link
Collaborator

@Lakshmishri
Can we align the items on mobile to the align-items: flex-start;? Now it looks weird IMO

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 13, 2023

Page Scores Audits Google
/drafts/lakshmi/v2/tabbed-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb
Copy link
Collaborator

@Lakshmishri Can we align the items on mobile to the align-items: flex-start;? Now it looks weird IMO

@TomaszDziezykNetcentric I’ve updated the branch together with two other changes. Could you check the PR?

@cogniSyb cogniSyb added the Bugfix Something isn't working label Nov 13, 2023
@cogniSyb cogniSyb changed the title Refactor Tabbed carousel Tabbed carousel multiple instances get combined #109 Nov 13, 2023
@cogniSyb cogniSyb merged commit ac79c85 into develop Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taimurCognizant taimurCognizant taimurCognizant approved these changes

@markovukiceviccn markovukiceviccn markovukiceviccn approved these changes

@cogniSyb cogniSyb cogniSyb approved these changes

@TomaszDziezykNetcentric TomaszDziezykNetcentric TomaszDziezykNetcentric approved these changes

@SantiagoHomps-NC SantiagoHomps-NC SantiagoHomps-NC approved these changes

Assignees
No one assigned
Labels
Bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Lakshmishri @TomaszDziezykNetcentric @cogniSyb @SantiagoHomps-NC @markovukiceviccn @taimurCognizant