Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards #23

Closed
cogniSyb opened this issue Aug 15, 2023 · 2 comments · Fixed by #48
Closed

Cards #23

cogniSyb opened this issue Aug 15, 2023 · 2 comments · Fixed by #48
Assignees
@TomaszDziezykNetcentric
Labels
Homepage MVP Must have for october PDP Redesign FE Redesign FE task Trucks and segments
Milestone
MT Trucks and Seg...

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 15, 2023 •
edited
Loading

Known in the design as article list. On the homepage we show three last published articles. Placed just above the footer, it’s already present on the current website as the cards block.

Requirements

  • Full width graphite background (see secondary palette)
  • Heading with marker above it
  • Three cards, containing:
    • Image
    • Heading
    • Text
    • Link with chevron
  • On mobile, the cards are placed below each other
  • On tablet, we’ll handle the design as on current website: two cards on one line when they fit, with one card below it centred
  • On desktop, all cards will be placed on one line

Sizing

  • All cards have 24px padding
  • The gap between cards is 16px
  • On desktop, the cards will be justified. Together including spacing they’ll be as wide as the maximum content container (1040px)
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 17, 2023
@tdziezykDS
#23 Add card block
39c7281
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 17, 2023
@tdziezykDS
#23 Update cards tablet styles
a349f12
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 17, 2023
@tdziezykDS
#23 Css fix
a03fc8d
Merged
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 18, 2023
@tdziezykDS
#23 Update css
bb98819
@shirin27 shirin27 added the MVP Must have for october label Aug 18, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 28, 2023
@tdziezykDS
#23 Fixes after CR
2076a1a
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 30, 2023
@tdziezykDS
#23 Update css
cb84a50
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 31, 2023
@tdziezykDS
#23 Fix h1 styling
2a32ed0
TomaszDziezykNetcentric pushed a commit that referenced this issue Aug 31, 2023
@tdziezykDS
#23 Fix headings font weight
57fb29b
TomaszDziezykNetcentric pushed a commit that referenced this issue Sep 5, 2023
@tdziezykDS
#23 Fix after merge
d7a5367
TomaszDziezykNetcentric pushed a commit that referenced this issue Sep 5, 2023
@tdziezykDS
#23 Fix breakpoint
59842c6
TomaszDziezykNetcentric pushed a commit that referenced this issue Sep 5, 2023
@tdziezykDS
#23 Changes after CR
06c07a7
TomaszDziezykNetcentric pushed a commit that referenced this issue Sep 5, 2023
@tdziezykDS
#23 Changes after CR
154ec19
@cogniSyb cogniSyb mentioned this issue Sep 6, 2023
Closed
@Andrei-Boiangiu Andrei-Boiangiu mentioned this issue Sep 7, 2023
Closed
@Andrei-Boiangiu
Copy link
Collaborator

reopening to be discussed with a solution for Major Bug #71 and to be retested once its fixed

@Andrei-Boiangiu
Copy link
Collaborator

bug moved as Minor and ticket moved as Done until further notice

@shirin27 shirin27 mentioned this issue Sep 11, 2023
Open
This was referenced Oct 11, 2023
Closed
Closed
@DanielaPedrochevd DanielaPedrochevd added this to the MT Homepage milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomaszDziezykNetcentric TomaszDziezykNetcentric

Labels
Homepage MVP Must have for october PDP Redesign FE Redesign FE task Trucks and segments
Projects
None yet
Milestone
MT Trucks and Segments
Development

Successfully merging a pull request may close this issue.

23 card block Netcentric/vg-macktrucks-com-rd
5 participants
@TomaszDziezykNetcentric @Andrei-Boiangiu @cogniSyb @shirin27 @DanielaPedrochevd