Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards Block Variant: 3-card row with button #115

Closed
2 tasks
Gonzalo-CG opened this issue Oct 17, 2023 · 3 comments
Closed
2 tasks

Cards Block Variant: 3-card row with button #115

Gonzalo-CG opened this issue Oct 17, 2023 · 3 comments
Assignees
@Gonzalo-CG
Labels
PDP
Milestone
MT PDP

Comments

@Gonzalo-CG
Copy link
Collaborator

Gonzalo-CG commented Oct 17, 2023 •
edited
Loading

Description

A new variation for the Cards Block will be developed to achieve the design shown on 3-card row Cards with CTA - Figma, this block is used on the PDP LR Page - Figma.

3-card row Cards with CTA design:

Acceptance Criteria

  • A new block variation is available for authors to use in order to achieve the "3-card row" look.
  • The 3-card row variant has the same design for Desktop & mobile as shown in Figma.
@Gonzalo-CG Gonzalo-CG added the PDP label Oct 17, 2023
@BeckyMedlin
Copy link
Collaborator

@Gonzalo-CG Please correct the AC as it references 4-card, not 3-card row.
Does the background requirement need to be included in the AC?

@DanielaPedrochevd DanielaPedrochevd added this to the MT PDP milestone Oct 31, 2023
@Gonzalo-CG Gonzalo-CG mentioned this issue Nov 6, 2023
Open
1 task
@Gonzalo-CG
Copy link
Collaborator Author

This issue will be solved in conjunction with #159

@cogniSyb cogniSyb changed the title Cards Block Variant: 3-card row with CTA Cards Block Variant: 3-card row with button Nov 13, 2023
@cogniSyb cogniSyb mentioned this issue Nov 13, 2023
Merged
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
as tested on
https://115-cards-with-button--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/syb/cards

left open for PR review for @cogniSyb's points to be confirmed

cogniSyb added a commit that referenced this issue Nov 15, 2023
@cogniSyb
Cards Block Variant: 3-card row with button #115 (#168)
e78ed5e 
* add possibility to use small buttons in v2-cards
* add variant without padding/background
* add variant with different image aspect ratio
* add variant with H4-style heading
@WendyKruger WendyKruger mentioned this issue Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gonzalo-CG Gonzalo-CG

Labels
PDP
Projects
None yet
Milestone
MT PDP
Development

When branches are created from issues, their pull requests are automatically linked.

115-cards-with-button Netcentric/vg-macktrucks-com-rd
5 participants
@Andrei-Boiangiu @cogniSyb @Gonzalo-CG @BeckyMedlin @DanielaPedrochevd