Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warranty and Protection plan - gray cards #58

Closed
Lakshmishri opened this issue Aug 28, 2023 · 7 comments
Closed

Warranty and Protection plan - gray cards #58

Lakshmishri opened this issue Aug 28, 2023 · 7 comments
Assignees
@Andrei-Boiangiu
Labels
PDP
Milestone
MT PDP

Comments

@Lakshmishri
Copy link
Collaborator

Lakshmishri commented Aug 28, 2023 •
edited by shirin27
Loading

  • Figma design
  • This can be implemented using existing cards block with variation for gray background
  • Design for mobile/tablet view is missing however the cards will be displayed after each other
  • Links will have the following states
@Lakshmishri Lakshmishri added PDP MVP Must have for october labels Aug 28, 2023
@shirin27
Copy link
Collaborator

shirin27 commented Sep 4, 2023

Related to #64 , should be solved by that, only testing needed

@BeckyMedlin
Copy link
Collaborator

@DanielaPedrochevd Not sure why this one is flagged as "On Hold". Please confirm if the team is waiting on anything before they can action this ticket, or if it's only a dependency on #64, which is in the current sprint.

@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Oct 4, 2023 •
edited
Loading

We are only waiting for #64 once it's close we will move this to a ready for testing stage and then done.

@DanielaPedrochevd
Copy link
Collaborator

After discussing with the team, this issue has to be picked up, it's not only testing so we will pick it up in sprint 4 as planned. Already refined and estimated.

@DanielaPedrochevd
Copy link
Collaborator

Moved to sprint 5 and related to #120

@DanielaPedrochevd DanielaPedrochevd removed the MVP Must have for october label Oct 23, 2023
@cogniSyb cogniSyb self-assigned this Oct 25, 2023
@cogniSyb cogniSyb changed the title Warranty and Protection plan Warranty and Protection plan - gray cards Oct 25, 2023
@cogniSyb cogniSyb mentioned this issue Oct 25, 2023
Merged
@cogniSyb cogniSyb added Design Question RE/Dev team has open questions regarding the designs. and removed Design Question RE/Dev team has open questions regarding the designs. labels Oct 26, 2023
@cogniSyb
Copy link
Collaborator

Matt Grunstad confirmed via Slack that it’s fine to use Tertiary Light Warm Gray, #F7F6F3 for the background of the cards.

@cogniSyb cogniSyb assigned Andrei-Boiangiu and unassigned cogniSyb Oct 26, 2023
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
as tested on https://58-gray-cards--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/syb/cards

cogniSyb added a commit that referenced this issue Oct 31, 2023
@cogniSyb
Warranty and Protection plan - gray cards #58 (#152)
ab5b3f7 
* add cards variant
* refactor class name
@WendyKruger WendyKruger added this to the MT PDP milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrei-Boiangiu Andrei-Boiangiu

Labels
PDP
Projects
None yet
Milestone
MT PDP
Development

When branches are created from issues, their pull requests are automatically linked.

58-gray-cards Netcentric/vg-macktrucks-com-rd
7 participants
@Lakshmishri @Andrei-Boiangiu @cogniSyb @WendyKruger @shirin27 @BeckyMedlin @DanielaPedrochevd