Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Section metadata options: background colour & image #64

Closed
cogniSyb opened this issue Aug 30, 2023 · 3 comments
Closed

FR: Section metadata options: background colour & image #64

cogniSyb opened this issue Aug 30, 2023 · 3 comments
Assignees
@Andrei-Boiangiu
Labels
General GoLive This task is needed for the Go Live HL estimate MVP Must have for october
Milestone
MT PDP

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 30, 2023 •
edited by shirin27
Loading

Sections can have a background colour defined. In some cases, a dotted pattern is used as a background image. A content editor should be able to activate this for several components. This issue is related to Netcentric/vg-volvotrucks-us-rd#47

  • Use CSS variables to change the colour of the blocks
  • Check the existing v2 blocks (aprox. 4 blocks: Hero, columns, testimonial, cards) to solve the issue of having different text backgrounds against different bg colours
@cogniSyb cogniSyb added General MVP Must have for october labels Aug 30, 2023
@cogniSyb cogniSyb mentioned this issue Aug 30, 2023
Closed
@shirin27 shirin27 mentioned this issue Sep 4, 2023
Closed
@DanielaPedrochevd
Copy link
Collaborator

Agile requirement
As a content editor, I'm able to activate a background color defined, in some cases I can define an imaged with a dotted pattern and the text in the section should look ok.

Description
Use CSS variables to change the colour of the blocks
Check the existing v2 blocks (aprox. 4 blocks: Hero, columns, testimonial, cards) to solve the issue of having different text backgrounds against different bg colours

Acceptance Criteria

  1. Check the V2 esixting blocks using CSS variables.
  2. Check above-mentioned blocks with the different text colours and bg colours of the sections.

@kesiah kesiah self-assigned this Sep 26, 2023
@kesiah kesiah mentioned this issue Sep 27, 2023
Merged
@markovukiceviccn markovukiceviccn mentioned this issue Sep 28, 2023
Merged
@cogniSyb cogniSyb assigned cogniSyb and unassigned kesiah Oct 9, 2023
@cogniSyb cogniSyb assigned Andrei-Boiangiu and unassigned cogniSyb Oct 18, 2023
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
as tested on
https://64-section-bg--vg-macktrucks-com-rd--netcentric.hlx.page/homepage
https://64-section-bg--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/laura/pdp

@cogniSyb
Copy link
Collaborator Author

As discussed in meeting with design agency, the gray background overlap is removed for the testimonial. Instead we’ll use the gray background for the whole section.

cogniSyb added a commit that referenced this issue Oct 19, 2023
@kesiah @cogniSyb
Section metadata options: background colour & image #64 (#93)
a046665 
* section background color + image
* improve section spacings, adjust max width to 1920
* prevent regression on non-redesign pages
* add repeating dot pattern
* prevent dot pattern clipping when supported
* fix alignment of testimonial
* typography fixes for several blocks
* add background to solutions container
* remove unnecessary divs from solutions block
* fix sizing and typography of columns

---------

Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
@DanielaPedrochevd DanielaPedrochevd added the GoLive This task is needed for the Go Live label Oct 23, 2023
@DanielaPedrochevd DanielaPedrochevd modified the milestones: MT Homepage, MT PDP Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrei-Boiangiu Andrei-Boiangiu

Labels
General GoLive This task is needed for the Go Live HL estimate MVP Must have for october
Projects
None yet
Milestone
MT PDP
Development

No branches or pull requests
5 participants
@kesiah @Andrei-Boiangiu @cogniSyb @shirin27 @DanielaPedrochevd