Feature/shengweiw/aurora hardware #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShengweiWang
commented
May 16, 2023
ShengweiWang
commented
- Using db.xx instances instead of normal ec2 instances, to get a more accurate cost estimation
- Adding IO cost estimation
abersnaze
reviewed
May 19, 2023
| @@ -161,7 +180,7 @@ def _estimate_aurora_regional( | |||
| extra_model_arguments: Dict[str, Any], | |||
| ) -> Optional[CapacityPlan]: | |||
| instance_family = instance.family | |||
| if instance_family not in ("x2g", "r6g", "r6i", "r5", "t4g"): # TODO: split db instance and ec2 instance | |||
| if instance_family not in ("db.x2g", "db.r6g", "db.r6i", "db.r5", "db.t4g"): | |||
There was a problem hiding this comment.
could this be not instance_family.startswith('db.')?
There was a problem hiding this comment.
There are only some of the instance families are supported in Aurora. For example, db.m5 is supported by RDS but not Aurora.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.