-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cass SNAPSHOT JMX status, snapshot version, last validated timestamp. Changes to Servlet API. #770
Conversation
…amp. Changes to Servlet API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look at the tests yet, but overall just some minor fix n ships and clarification questions.
priam/src/main/java/com/netflix/priam/backup/BackupMetadata.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/backup/BackupStatusMgr.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/backup/BackupStatusMgr.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/backup/BackupStatusMgr.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/resources/BackupServletV2.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/resources/BackupServletV2.java
Outdated
Show resolved
Hide resolved
priam/src/main/java/com/netflix/priam/resources/BackupServletV2.java
Outdated
Show resolved
Hide resolved
if (!backupRestoreConfig.enableV2Backups()) { | ||
if (!backupRestoreConfig.enableV2Backups() | ||
&& backupRestoreConfig | ||
.getSnapshotMetaServiceCronExpression() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for the rollout period can we leave a comment indicating that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Irrespective of the rollout, no point running TTL service, if V2 backups are not enabled.
No description provided.