Implemented RefCount Operator #407
Conversation
|
RxJava-pull-requests #310 ABORTED |
|
I notice this was aborted due to a timeout in the Scala language adaptors tests. I didn't make any changes in this area, so am guessing there's an intermittent bug somewhere. |
|
RxJava-pull-requests #311 ABORTED |
|
The problem with the Scala tests should be fixed by #408, but that only saves 48 seconds. There must be also another problem with the cloudbees-pull-request-builder... |
|
Hopefully the builds should improve now, I've changed the CloudBees config to allow twice as much time. |
|
Thank you for implementing Will review it and merge as soon as I can. |
| * @return a {@link Observable} | ||
| * @param that a {@link ConnectableObservable} | ||
| */ | ||
| public static <T> Observable<T> refCount(ConnectableObservable<T> that) { |
There was a problem hiding this comment.
Should this be a no arg instance method?
There was a problem hiding this comment.
Hi George, thanks for taking the time to review the code. Indeed there is a no arg instance method. I also included the static version to follow the pattern using in Observable.java where many operators have static and instance variants that delegate to the statics. It has an added bonus that it means you can test the operator on a mocked instance. I'm happy to remove the static method and test against a concrete instance though. Cheers, John
There was a problem hiding this comment.
Actually, on closer inspection, those operations on Observable that have both static and instance variants like concat, merge and zip could be special cases. I'll remove the static method and rejig the tests.
|
RxJava-pull-requests #314 ABORTED |
Manual Merge of Pull Request #407
|
Thanks @johnhmarks for submitting this. |
Manual Merge of Pull Request ReactiveX#407
Please note that I placed the unit tests under the test root rather than inline with the implementation as has been done for other operators. This is due to a bug in IDEA that prohibits running unit tests in folders designated as source rather than test. I can see that a bunch of other operators follow this convention so hopefully that's okay.