Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run RxScalaDemo on each build #408

Merged
merged 1 commit into from
Sep 25, 2013

Conversation

samuelgruetter
Copy link
Contributor

On my last pull request, I forgot to uncomment the line which ignores RxScalaDemo, so currently it is executed on each build, even though it does no automatic testing. And since RxScalaDemo takes about 48 seconds, this significantly increases build time. Sorry for this...

After this change, the complete build took 3 mins 33.932 secs on my 3 years old laptop, so if cloudbees can't build it in 10 min, there might be something else not properly working...

because it does not do automatic testing
@cloudbees-pull-request-builder

RxJava-pull-requests #312 ABORTED

@samuelgruetter
Copy link
Contributor Author

So this time it was ABORTED because scala is too big and their internet connection is too slow:

Download http://repo1.maven.org/maven2/org/scala-lang/scala-library/2.10.3-RC3/scala-library-2.10.3-RC3.pom
Download http://repo1.maven.org/maven2/org/scala-lang/scala-library/2.10.3-RC3/scala-library-2.10.3-RC3.jar
Download http://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.10.3-RC3/scala-compiler-2.10.3-RC3.pom
Download http://repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.10.3-RC3/scala-reflect-2.10.3-RC3.pom
Download http://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.10.3-RC3/scala-compiler-2.10.3-RC3.jar
Download http://repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.10.3-RC3/scala-reflect-2.10.3-RC3.jar

@benjchristensen
Copy link
Member

I just increased the timeout on the build from 20 to 40 minutes to see if it helps things. CloudBees is not fast.

benjchristensen added a commit that referenced this pull request Sep 25, 2013
Do not run RxScalaDemo on each build
@benjchristensen benjchristensen merged commit 68715c2 into ReactiveX:master Sep 25, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
* Changed all external dependencies to compileOnly so that Resilience4j does not introduce too many transitive dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants