Do not run RxScalaDemo on each build #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it does not do automatic testing
|
RxJava-pull-requests #312 ABORTED |
|
So this time it was ABORTED because scala is too big and their internet connection is too slow: |
|
I just increased the timeout on the build from 20 to 40 minutes to see if it helps things. CloudBees is not fast. |
benjchristensen
added a commit
that referenced
this pull request
Sep 25, 2013
Do not run RxScalaDemo on each build
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Do not run RxScalaDemo on each build
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
* Changed all external dependencies to compileOnly so that Resilience4j does not introduce too many transitive dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my last pull request, I forgot to uncomment the line which ignores
RxScalaDemo, so currently it is executed on each build, even though it does no automatic testing. And sinceRxScalaDemotakes about 48 seconds, this significantly increases build time. Sorry for this...After this change, the complete build took 3 mins 33.932 secs on my 3 years old laptop, so if cloudbees can't build it in 10 min, there might be something else not properly working...