Timer and Delay #576
Merged
Timer and Delay #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #513 SUCCESS |
Closed
This was referenced Dec 11, 2013
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Timer and Delay
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @headinthebox, it's possible to implement
delayin terms oftimer,mapandconcat.However, there were some tricky points:
concatsubscribes to them), I had to usereplay.delay.I hope that there aren't too many further tricky points that I missed, especially since #552 adds confusion. So this will need another review once #552 is fixed.
Thanks @jmhofer for your previous work on
delay, I reused it where possible (see commit messages).