Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ConnectableObservable #717

Merged
merged 1 commit into from
Jan 3, 2014
Merged

Added ConnectableObservable #717

merged 1 commit into from
Jan 3, 2014

Conversation

headinthebox
Copy link
Contributor

Fixed test
Added overload for scan
Added trivial test for scan

Fixed test
Added overload for scan
Added trivial test for scan
@cloudbees-pull-request-builder

RxJava-pull-requests #634 SUCCESS
This pull request looks good

@samuelgruetter
Copy link
Contributor

While we're on scan: There's a small inconsistency with fold: In the Scala collections, there are operations called fold, reduce and scan, which take an associative accumulator, and may process the list in any order to improve performance. If you want a guaranteed order and/or your accumulator is not associative, you can use foldLeft/foldRight, reduceLeft/reduceRight, scanLeft/scanRight. But now, with Observables, only the xxxLeft methods make sense. To be very consistent with Scala collections, we should thus call them foldLeft, reduceLeft, and scanLeft, and have no operators called fold, reduce and scan. Or the second option would be to call them just fold, reduce and scan, since there's only one version per operator, so we would have to rename the operator currently called foldLeft to fold.

benjchristensen added a commit that referenced this pull request Jan 3, 2014
@benjchristensen benjchristensen merged commit 7a75d4b into ReactiveX:master Jan 3, 2014
@headinthebox headinthebox deleted the ScalaPublishFix branch January 21, 2014 21:29
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants