Various Changes While Fixing GroupBy #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support synchronous unsubscribe now
- Splitting them allows clearer code and avoids use of queue for normal merge.
- used in MergeMaxConcurrent and ObserveOn - allows for blocking onNext calls when full while still supporting unsubscribe.
Make this public so that operator chaining can use it. Usage would be someObservable.nest().lift(f) for lifting a function that expects Observable<Observable<T>> such as `repeat`.
- There were bugs in the implementation, this fixes some of them. In particular, it was unsubscribing from the parent when all children were completed, and that would unsubscribe even if new groups were going to come. - There are still problems related to `subscribeOn` and the "time gap" that are being played with. Unit tests related to that are still failing.
It had been changed to only support >0, put it back to >=0
The new OperatorMerge class still exists, but reverting this one. I messed up the thread safety and don't have time to figure it out.
- stressing it further while hunting down non-determism
|
RxJava-pull-requests #768 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Feb 11, 2014
Various Changes While Fixing GroupBy
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…hen a BulkheadFullException occurs ReactiveX#847 The ThreadPoolBulkhead is does not return a CompletionStage when a task could not be submitted, because the Bulkhead is full. The ThreadPoolBulkhead throws a BulkheadFullException instead. Analog to the ThreadPoolExecutor which throws the RejectedExecutionException. The BulkheadFullException is not handled correctly by the BulkheadAspect. The BulkheadAspect should convert the BulkheadFullException into a exceptionally completed future so that the FallbackDecorator works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.