Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for buffer not stopping when unsubscribed. #596

Merged
merged 1 commit into from
Dec 10, 2013
Merged

Fix for buffer not stopping when unsubscribed. #596

merged 1 commit into from
Dec 10, 2013

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 9, 2013

Issue #559

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #530 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Dec 10, 2013
@benjchristensen
Merge pull request #596 from akarnokd/BufferFix1
6696c56 
Fix for buffer not stopping when unsubscribed.
@benjchristensen benjchristensen merged commit 6696c56 into ReactiveX:master Dec 10, 2013
This was referenced Dec 10, 2013
Closed
Closed
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#596 from akarnokd/BufferFix1
c8be88d 
Fix for buffer not stopping when unsubscribed.
@akarnokd akarnokd deleted the BufferFix1 branch January 13, 2014 10:02
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@RobWin
Issue ReactiveX#596: The Spring Boot fallback method is not invoked w…
79378fb 
…hen a BulkheadFullException occurs ReactiveX#847

The ThreadPoolBulkhead is does not return a CompletionStage when a task could not be submitted, because the Bulkhead is full. The ThreadPoolBulkhead throws a BulkheadFullException instead. Analog to the ThreadPoolExecutor which throws the RejectedExecutionException. The BulkheadFullException is not handled correctly by the BulkheadAspect.
The BulkheadAspect should convert the BulkheadFullException into a exceptionally completed future so that the FallbackDecorator works as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akarnokd @cloudbees-pull-request-builder @benjchristensen