rxjava-scala improvements and reimplemented the amb operator
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #887 SUCCESS |
| return; | ||
| } | ||
| observer.onError(e); | ||
| subscriber.onError(e); | ||
| } | ||
|
|
||
| private boolean isSelected() { |
There was a problem hiding this comment.
I wonder if this could be simplified to only a single get() call:
int ch = choice.get();
if (ch == NONE) {
return choice.compareAndSet(NONE, index);
}
return ch == index;Since this method is called for every onNext() for the winner, this change might reduce the overhead by 2; haven't benchmarked it. In addition, switching to a volatile int choice + double-check synchronization might be a bit faster even. Thoughts?
There was a problem hiding this comment.
Not quite sure about "volatile + double-check". If JVM can inline "choice.get()", it should be same as "accessing a volatile var".
|
RxJava-pull-requests #888 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Mar 13, 2014
rxjava-scala improvements and reimplemented the `amb` operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR did the following improvements:
amb,delay,delaySubscriptionin rxjava-scala.amboperator.