Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimization for primitive Dynamic***Property classes #369

Merged
merged 12 commits into from
Aug 19, 2016
Merged

Performance optimization for primitive Dynamic***Property classes #369

merged 12 commits into from
Aug 19, 2016

Commits on Nov 28, 2015

  1. Attempt to integrate my CachedProperties implementation into Archaius 

    - Added a simple benchmark to compare the implementations.

- Added an attempt at DynamicPrimitiveBooleanProperty which (unlike my CachedProperties) extends the normal PropertyWrapper.
    @kerumai
    kerumai committed Nov 28, 2015
    Configuration menu
    Copy the full SHA
    5abf02a View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2015

  1. Change the existing Dynamic*Property classes to cache their primitive… 

    … values

Changed tack to doing this to the existing classes instead of adding new implementations, so that existing users of get
the benefits too.

Added some tests to verify that updating of property values also updates the cached primitives.
    @kerumai
    kerumai committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    dad8bb0 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2015

  1. Change callbacks from java8 lambdas to java6 Runnable impls

    @kerumai
    kerumai committed Dec 1, 2015
    Configuration menu
    Copy the full SHA
    287e179 View commit details
    Browse the repository at this point in the history

  2. Fix unit-test that broke due to callbacks now being non-empty for Dyn… 

    …amicBooleanProperty
    @kerumai
    kerumai committed Dec 1, 2015
    Configuration menu
    Copy the full SHA
    67a75cb View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2015

  1. Changes related to PR feedback 

    - Replaced usage of the callback mechanism with overriding the propertyChanged() method.

- Removed unnecessary null check.

- Added a comparison with previous get() method impl in CachedPropertiesPerfTest.
    @kerumai
    kerumai committed Dec 2, 2015
    Configuration menu
    Copy the full SHA
    d2499d2 View commit details
    Browse the repository at this point in the history

  2. Make the new chooseValue() method in the Dynamic**Property classes be… 

    …have same as the previous get() method
    @kerumai
    kerumai committed Dec 2, 2015
    Configuration menu
    Copy the full SHA
    91eef78 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2015

  1. Stopped calling super.propertyChanged() in overridedden method of Dyn… 

    …amic*Property classes
    @kerumai
    kerumai committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    7e7e845 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2016

  1. Change to having separate CachedDynamic*Property classes instead of c… 

    …hanging the existing Dynamic*Property classes
    @kerumai
    kerumai committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    cc10674 View commit details
    Browse the repository at this point in the history

  2. Revert changes to PropertyWrapper to register the Dynamic*Property cl… 

    …asses, as no longer needed
    @kerumai
    kerumai committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    d4a233e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2016

  1. Revert the whitespace formatting changes

    @kerumai
    kerumai committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    2de5ae0 View commit details
    Browse the repository at this point in the history

  2. Add some more info the CachedPropertiesPerfTest output

    @kerumai
    kerumai committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    d3eefc7 View commit details
    Browse the repository at this point in the history

  3. Trying again at reverting the superfluous whitespace changes

    @kerumai
    kerumai committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    debec15 View commit details
    Browse the repository at this point in the history