Basic instrumentation changes behind a flag #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # archaius-core/src/main/java/com/netflix/config/AbstractPollingScheduler.java # archaius-core/src/main/java/com/netflix/config/ConcurrentCompositeConfiguration.java # archaius-core/src/main/java/com/netflix/config/DefaultContextualPredicate.java # archaius-core/src/main/java/com/netflix/config/DynamicContextualProperty.java # archaius-core/src/main/java/com/netflix/config/DynamicPropertyFactory.java # archaius-core/src/main/java/com/netflix/config/WatchedUpdateResult.java # archaius-core/src/test/java/com/netflix/config/PollingSourceTest.java # archaius-etcd/src/main/java/com/netflix/config/source/EtcdConfigurationSource.java # archaius-zookeeper/src/main/java/com/netflix/config/source/ZooKeeperConfigurationSource.java # build.gradle # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties # gradlew # gradlew.bat
| return usedProperties; | ||
| } | ||
|
|
||
| private Set<String> usedProperties = new HashSet<>(); |
There was a problem hiding this comment.
Either this field should be a ConcurrentHashMap like the stackTraces one, or neither should because they'll both be subjected to the very same possible races.
Also, could they both be final?
There was a problem hiding this comment.
Updated usedProperties to also be backed by a ConcurrentHashMap and changed both fields to be final as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps track of usage data through ConcurrentCompositeConfiguration when enabled by the system property and also surfaces an uninstrumented endpoint for any calls that should not be recorded.
Also includes the ability to record stack traces of call sites (useful for debugging, but should not be used in prod).