-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview of proxy inclusion #112
Conversation
…s, such as windows proxies, passwords, etc. Intended to be reviewed by Joe Sondow
…f the timezone it is run in
latest commit (ad7a0c3) contains a patch that fixes a brittle test. Problem with the test is that it will not work in Europe on a machine that uses a European timezone setting |
I left a few comments, but otherwise looks good. |
Thanks, I will clean up as you suggested. http://hc.apache.org/httpcomponents-core-ga/httpcore/apidocs/org/apache/http/HttpHost.html |
…w US time zones but not in Europe. Now using Regular expressions. I think what is being tested here is the fact whether something is human-readable rather than the exact dates/times so I feel that the new approach is valid and less brittle
Latest commit (57a371b) contains a patch to make QueueControllerTests.groovy less brittle (does not work in European timezone). |
…ne in which it is executed.
All done as far as test failures in Europe were concerned:-) With this latest commit (799a08d) all tests are green in Europe/Berlin. Interesting to note that all test failures stemmed from the fact that the test environment was assumed to be running in a set of selected timezones (PST, PDT, UTC) |
Before the patch concerning http proxy can be merged in, the MockAmazon*Client classes need a new constructor signature. I am working on a patch... |
…e a ClientConfiguration (triggered by need to have a HTTP proxy)
Here is the summary of all changes contained in this pull request and what belongs to what Three brittle tests fixed (timezone issues), the commits are Include possibility to configure an HTTP proxy (this time only via editing config file). The commits are |
lgtm |
As far as making this more complete is concerned, here's what I would like to see:
|
LGTM. I think the additional features you have in mind could be added as separate pull requests in the future after we test and merge this one. Changing the config after initial setup is likely to consist of wiki instructions for editing Config.groovy in a text editor. The init process for making Config.groovy is meant as a jump-starter for people to try out Asgard quickly. |
I totally agree and look forward to continue with the implementation once this pull request is merged, provided it passes the quality gate first. BTW: It would be super interesting to learn about the roadmap and maybe about features that are planned but not yet assigned. |
@mkrogemann We have plans to make information about enhancements to Asgard more transparent. @joesondow @jgritman Since this lgte is it time to merge it? |
Went ahead with the merge. |
please review and give me feedback. I am happy to make this more complete. As it is, It helps with my personal challenge right now which is to sit behind a proxy (no authentication).
With this patch and appropriate additions to ~/.asgard/Config.groovy, such as
proxy {
host="something.com"
port=8080
}
I can now work through our proxy. By commenting the above, I can work without proxy again when I'm in a different network.
I think it would make sense to extend the initial config page and also to allow editing the config after initial configuration is done.