Add a unique colors list to the palettes for use by heatmaps. #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an equals override to palettes for unit testing.
atlas-chart/src/main/scala/com/netflix/atlas/chart/model/Palette.scala
Outdated
Show resolved
Hide resolved
Convert the Palette to require an ArraySeq of colors. Rename the parameter and implement colors() to avoid code changing in other places.
atlas-chart/src/main/scala/com/netflix/atlas/chart/model/Palette.scala
Outdated
Show resolved
Hide resolved
atlas-chart/src/test/scala/com/netflix/atlas/chart/model/PaletteSuite.scala
Outdated
Show resolved
Hide resolved
brharrington
approved these changes
Jan 13, 2023
manolama
added a commit
to manolama/atlas
that referenced
this pull request
Jan 13, 2023
Convert the Palette to require an ArraySeq of colors. Rename the parameter and implement colors() to avoid code changing in other places. This allows the full set of colors to be accessed directly for use with things like heatmaps.
manolama
added a commit
to manolama/atlas
that referenced
this pull request
May 22, 2024
Convert the Palette to require an ArraySeq of colors. Rename the parameter and implement colors() to avoid code changing in other places. This allows the full set of colors to be accessed directly for use with things like heatmaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an equals override to palettes for unit testing.